Commit 768acf46 authored Dec 22, 2015 by Chen-Yu Tsai Committed by Mauro Carvalho Chehab Dec 23, 2015

[media] rc: sunxi-cir: Initialize the spinlock properly



The driver allocates the spinlock but fails to initialize it correctly.
The kernel reports a BUG indicating bad spinlock magic when spinlock
debugging is enabled.

Call spin_lock_init() on it to initialize it correctly.

Fixes: b4e3e59f ("[media] rc: add sunxi-ir driver")

Signed-off-by: Chen-Yu Tsai <wens@csie.org>
Acked-by: Hans de Goede <hdegoede@redhat.com>
Cc: stable@vger.kernel.org
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>

parent 4020c18a

drivers/media/rc/sunxi-cir.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -153,6 +153,8 @@ static int sunxi_ir_probe(struct platform_device *pdev)
		if (!ir)
		return -ENOMEM;

		spin_lock_init(&ir->ir_lock);

		if (of_device_is_compatible(dn, "allwinner,sun5i-a13-ir"))
		ir->fifo_size = 64;
		else