Commit 7633fb95 authored Apr 09, 2014 by Linus Walleij

gpio: set data first, then chip and handler



During irq mapping, in irq_set_chip_and_handler() the process
of setting this up may incur calls to lock the irqchip, which
in turn may need to dereference and use the chip data. So set
the data first, then set the chip and handler.

Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

parent c9eaa447

drivers/gpio/gpiolib.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1387,8 +1387,8 @@ static int gpiochip_irq_map(struct irq_domain *d, unsigned int irq,
		{
		struct gpio_chip *chip = d->host_data;

		irq_set_chip_and_handler(irq, chip->irqchip, chip->irq_handler);
		irq_set_chip_data(irq, chip);
		irq_set_chip_and_handler(irq, chip->irqchip, chip->irq_handler);
		#ifdef CONFIG_ARM
		set_irq_flags(irq, IRQF_VALID);
		#else