Commit 7630abd0 authored May 08, 2011 by Joe Perches Committed by James Bottomley May 17, 2011

[SCSI] hpsa: Change memset using sizeof(ptr) to sizeof(*ptr)



Not at all sure this is correct or appropriate to change,
but this seems odd.

Found via coccinelle script

@@
type T;
T* ptr;
expression E1;
@@

* memset(E1, 0, sizeof(ptr));

Signed-off-by: Joe Perches <joe@perches.com>
Acked-by: Stephen M. Cameron <scameron@beardog.cce.hp.com>
Signed-off-by: James Bottomley <jbottomley@parallels.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>

parent 51f52a47

drivers/scsi/hpsa.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1329,7 +1329,7 @@ static void hpsa_scsi_do_simple_cmd_with_retry(struct ctlr_info *h,
		int retry_count = 0;

		do {
		memset(c->err_info, 0, sizeof(c->err_info));
		memset(c->err_info, 0, sizeof(*c->err_info));
		hpsa_scsi_do_simple_cmd_core(h, c);
		retry_count++;
		} while (check_for_unit_attention(h, c) && retry_count <= 3);