Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 750acdd7 authored by Johan Hovold's avatar Johan Hovold
Browse files

USB: serial: iuu_phoenix: remove unused buffer from open 



Remove code that allocated but never used a buffer during open.

Reviewed-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
parent 3c0e25d8

drivers/usb/serial/iuu_phoenix.c

+1 −14
Original line number Diff line number Diff line
@@ -976,7 +976,6 @@ static int iuu_open(struct tty_struct *tty, struct usb_serial_port *port) 
{

	struct usb_serial *serial = port->serial;

	struct device *dev = &port->dev;

	u8 *buf;

	int result;

	int baud;

	u32 actual;
@@ -991,20 +990,8 @@ static int iuu_open(struct tty_struct *tty, struct usb_serial_port *port) 
	usb_clear_halt(serial->dev, port->write_urb->pipe);

	usb_clear_halt(serial->dev, port->read_urb->pipe);



	buf = kmalloc(10, GFP_KERNEL);

	if (buf == NULL)

		return -ENOMEM;



	priv->poll = 0;



	/* initialize writebuf */

#define FISH(a, b, c, d) do { \

	result = usb_control_msg(port->serial->dev,	\

				usb_rcvctrlpipe(port->serial->dev, 0),	\

				b, a, c, d, buf, 1, 1000); \

	dev_dbg(dev, "0x%x:0x%x:0x%x:0x%x  %d - %x\n", a, b, c, d, result, \

				buf[0]); } while (0);



#define SOUP(a, b, c, d)  do { \

	result = usb_control_msg(port->serial->dev,	\

				usb_sndctrlpipe(port->serial->dev, 0),	\
@@ -1017,7 +1004,7 @@ static int iuu_open(struct tty_struct *tty, struct usb_serial_port *port) 
	/* sprintf(buf ,"%c%c%c%c",0x03,0x02,0x02,0x0); */



	SOUP(0x03, 0x02, 0x02, 0x0);

	kfree(buf);



	iuu_led(port, 0xF000, 0xF000, 0, 0xFF);

	iuu_uart_on(port);

	if (boost < 100)