Commit 74a5fef7 authored Dec 10, 2014 by Rasmus Villemoes Committed by Linus Torvalds Dec 10, 2014

lib/lcm.c: ensure correct result whenever it fits



Ensure that lcm(a,b) returns the mathematically correct result, provided
it fits in an unsigned long.  The current version returns garbage if a*b
overflows, even if the final result would fit.

Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Cc: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 7b212edf

lib/lcm.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -7,7 +7,7 @@
		unsigned long lcm(unsigned long a, unsigned long b)
		{
		if (a && b)
		return (a * b) / gcd(a, b);
		return (a / gcd(a, b)) * b;
		else if (b)
		return b;