Commit 73bfec0a authored Aug 13, 2018 by Andy Shevchenko Committed by Greg Kroah-Hartman Oct 10, 2018

gpiolib: acpi: Switch to cansleep version of GPIO library call



[ Upstream commit 993b9bc5c47fda86f8ab4e53d68c6fea5ff2764a ]

The commit ca876c7483b6

  ("gpiolib-acpi: make sure we trigger edge events at least once on boot")

added a initial value check for pin which is about to be locked as IRQ.
Unfortunately, not all GPIO drivers can do that atomically. Thus,
switch to cansleep version of the call. Otherwise we have a warning:

...
  WARNING: CPU: 2 PID: 1408 at drivers/gpio/gpiolib.c:2883 gpiod_get_value+0x46/0x50
...
  RIP: 0010:gpiod_get_value+0x46/0x50
...

The change tested on Intel Broxton with Whiskey Cove PMIC GPIO controller.

Fixes: ca876c7483b6 ("gpiolib-acpi: make sure we trigger edge events at least once on boot")
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Hans de Goede <hdegoede@redhat.com>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 9a5d3539

drivers/gpio/gpiolib-acpi.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -247,7 +247,7 @@ static acpi_status acpi_gpiochip_request_interrupt(struct acpi_resource *ares,

	gpiod_direction_input(desc);		gpiod_direction_input(desc);

	value = gpiod_get_value(desc);		value = gpiod_get_value_cansleep(desc);

	ret = gpiochip_lock_as_irq(chip, pin);		ret = gpiochip_lock_as_irq(chip, pin);
	if (ret) {		if (ret) {