Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 734b5aa9 authored by Bob Copeland's avatar Bob Copeland Committed by John W. Linville
Browse files

ath5k: use positive logic for HP laptop LEDs 



Helge Deller reports that HP laptops (NC4010 and NC6000) use active-
high signals to turn on the LEDs.  Previous code used active-low for
all devices.

Signed-off-by: default avatarBob Copeland <me@bobcopeland.com>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent 3e4242b9

drivers/net/wireless/ath5k/base.c

+2 −2
Original line number Diff line number Diff line
@@ -2581,8 +2581,6 @@ ath5k_init_leds(struct ath5k_softc *sc) 
	struct pci_dev *pdev = sc->pdev;

	char name[ATH5K_LED_MAX_NAME_LEN + 1];



	sc->led_on = 0;  /* active low */



	/*

	 * Auto-enable soft led processing for IBM cards and for

	 * 5211 minipci cards.
@@ -2591,11 +2589,13 @@ ath5k_init_leds(struct ath5k_softc *sc) 
	    pdev->device == PCI_DEVICE_ID_ATHEROS_AR5211) {

		__set_bit(ATH_STAT_LEDSOFT, sc->status);

		sc->led_pin = 0;

		sc->led_on = 0;  /* active low */

	}

	/* Enable softled on PIN1 on HP Compaq nc6xx, nc4000 & nx5000 laptops */

	if (pdev->subsystem_vendor == PCI_VENDOR_ID_COMPAQ) {

		__set_bit(ATH_STAT_LEDSOFT, sc->status);

		sc->led_pin = 1;

		sc->led_on = 1;  /* active high */

	}

	if (!test_bit(ATH_STAT_LEDSOFT, sc->status))

		goto out;