Commit 7348d82a authored May 12, 2009 by Daniel Ribeiro Committed by Linus Torvalds May 12, 2009

pxa2xx_spi: prevent panic case setup() fails



setup() may fail before ctldata is set, causing a kernel panic on
cleanup().

Signed-off-by: Daniel Ribeiro <drwyrm@gmail.com>
Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
Cc: Eric Miao <eric.y.miao@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 816dc3c8

drivers/spi/pxa2xx_spi.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -1373,6 +1373,9 @@ static void cleanup(struct spi_device *spi)
		{
		struct chip_data *chip = spi_get_ctldata(spi);

		if (!chip)
		return;

		if (gpio_is_valid(chip->gpio_cs))
		gpio_free(chip->gpio_cs);