Commit 73457165 authored Mar 14, 2016 by Mark Rustad Committed by Jeff Kirsher Apr 07, 2016

ixgbe: Correct length check for round up



The function ixgbe_host_interface_command actually uses a multiple
of word sized buffer to do its business, but only checks against
the actual length passed in. This means that on read operations it
could be possible to modify locations beyond the length passed in.
Change the check to round up in the same way, just to avoid any
possible hazard.

Signed-off-by: Mark Rustad <mark.d.rustad@intel.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>

parent 3775b814

drivers/net/ethernet/intel/ixgbe/ixgbe_common.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -3557,7 +3557,7 @@ s32 ixgbe_host_interface_command(struct ixgbe_hw hw, u32 buffer,
		if (buf_len == 0)
		return 0;

		if (length < (buf_len + hdr_size)) {
		if (length < round_up(buf_len, 4) + hdr_size) {
		hw_dbg(hw, "Buffer not large enough for reply message.\n");
		return IXGBE_ERR_HOST_INTERFACE_COMMAND;
		}