Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 72906ce0 authored by Dominik Behr's avatar Dominik Behr Committed by Mark Yao
Browse files

drm/rockchip: vop: fix window origin calculation 



VOP_WINx_DSP_ST does not require subtracting 1 from the values written to
it. It actually causes the screen to be shifted by one pixel.

Signed-off-by: default avatarMark Yao <mark.yao@rock-chips.com>
Tested-by: default avatarYakir Yang <ykk@rock-chips.com>
Reviewed-by: default avatarHeiko Stuebner <heiko@sntech.de>
Tested-by: default avatarHeiko Stuebner <heiko@sntech.de>
Signed-off-by: default avatarDominik Behr <dbehr@chromium.org>
Signed-off-by: default avatarMark Yao <mark.yao@rock-chips.com>
parent a8594f20

drivers/gpu/drm/rockchip/rockchip_drm_vop.c

+2 −2
Original line number Diff line number Diff line
@@ -959,8 +959,8 @@ static int vop_update_plane_event(struct drm_plane *plane, 
	val = (dest.y2 - dest.y1 - 1) << 16;

	val |= (dest.x2 - dest.x1 - 1) & 0xffff;

	VOP_WIN_SET(vop, win, dsp_info, val);

	val = (dsp_sty - 1) << 16;

	val |= (dsp_stx - 1) & 0xffff;

	val = dsp_sty << 16;

	val |= dsp_stx & 0xffff;

	VOP_WIN_SET(vop, win, dsp_st, val);

	VOP_WIN_SET(vop, win, rb_swap, rb_swap);