Commit 720a9717 authored Feb 24, 2013 by Julia Lawall Committed by Mark Brown Mar 04, 2013

regulator: s5m8767: adjust duplicate test

Delete successive tests to the same location.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/

)

// <smpl>
@s exists@
local idexpression y;
expression x,e;
@@

*if ( \(x == NULL\|IS_ERR(x)\|y != 0\) )
 { ... when forall
   return ...; }
... when != \(y = e\|y += e\|y -= e\|y |= e\|y &= e\|y++\|y--\|&y\)
*if ( \(x == NULL\|IS_ERR(x)\|y != 0\) )
 { ... when forall
   return ...; }
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>

parent 6dbe51c2

drivers/regulator/s5m8767.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -549,7 +549,7 @@ static int s5m8767_pmic_dt_parse_pdata(struct platform_device *pdev,

	rmode = devm_kzalloc(&pdev->dev, sizeof(rmode)		rmode = devm_kzalloc(&pdev->dev, sizeof(rmode)
	pdata->num_regulators, GFP_KERNEL);		pdata->num_regulators, GFP_KERNEL);
	if (!rdata) {		if (!rmode) {
	dev_err(iodev->dev,		dev_err(iodev->dev,
	"could not allocate memory for regulator mode\n");		"could not allocate memory for regulator mode\n");
	return -ENOMEM;		return -ENOMEM;