Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 71947828 authored by Markus Elfring's avatar Markus Elfring Committed by Mauro Carvalho Chehab
Browse files

[media] mn88473: One function call less in mn88473_init() after error 



The release_firmware() function was called by the mn88473_init() function even
if a previous function call "request_firmware" failed.
This implementation detail could be improved by the introduction of another
jump label.

Signed-off-by: default avatarMarkus Elfring <elfring@users.sourceforge.net>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
parent b5911384

drivers/staging/media/mn88473/mn88473.c

+3 −2
Original line number Original line Diff line number Diff line
@@ -225,7 +225,7 @@ static int mn88473_init(struct dvb_frontend *fe) 
	ret = request_firmware(&fw, fw_file, &client->dev);

	ret = request_firmware(&fw, fw_file, &client->dev);

	if (ret) {

	if (ret) {

		dev_err(&client->dev, "firmare file '%s' not found\n", fw_file);

		dev_err(&client->dev, "firmare file '%s' not found\n", fw_file);

		goto err;

		goto err_request_firmware;

	}

	}





	dev_info(&client->dev, "downloading firmware from file '%s'\n",

	dev_info(&client->dev, "downloading firmware from file '%s'\n",
@@ -261,9 +261,10 @@ static int mn88473_init(struct dvb_frontend *fe) 
	dev->warm = true;

	dev->warm = true;





	return 0;

	return 0;



err:

err:

	release_firmware(fw);

	release_firmware(fw);



err_request_firmware:

	dev_dbg(&client->dev, "failed=%d\n", ret);

	dev_dbg(&client->dev, "failed=%d\n", ret);

	return ret;

	return ret;

}

}