Commit 70812522 authored Oct 29, 2006 by Akinobu Mita Committed by Linus Torvalds Oct 30, 2006

[PATCH] isdn/gigaset: avoid cs->dev null pointer dereference

When gigaset_initbcs() is called, cs->dev is not initialized yet.  If
dev_alloc_skb() failed in this function, NULL poinster dereference will
happen at dev_warn().

Cc: Kai Germaschewski <kai.germaschewski@gmx.de>
Cc: Hansjoerg Lipp <hjlipp@web.de>
Cc: Tilman Schmidt <tilman@imap.cc>
Acked-by: Karsten Keil <kkeil@suse.de>
Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

parent 0e2d57fc

drivers/isdn/gigaset/common.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -616,7 +616,7 @@ static struct bc_state gigaset_initbcs(struct bc_state bcs,
		} else if ((bcs->skb = dev_alloc_skb(SBUFSIZE + HW_HDR_LEN)) != NULL)
		skb_reserve(bcs->skb, HW_HDR_LEN);
		else {
		dev_warn(cs->dev, "could not allocate skb\n");
		gig_dbg(DEBUG_INIT, "could not allocate skb\n");
		bcs->inputstate \|= INS_skip_frame;
		}