Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 70626d88 authored by Paul Gortmaker's avatar Paul Gortmaker Committed by Bjorn Helgaas
Browse files

PCI: pciehp: Make explicitly non-modular 



This code is not being built as a module by anyone:

  obj-$(CONFIG_HOTPLUG_PCI_PCIE)          += pciehp.o
  pciehp-objs                             := pciehp_core.o   \

  drivers/pci/pcie/Kconfig:config HOTPLUG_PCI_PCIE
  drivers/pci/pcie/Kconfig:  bool "PCI Express Hotplug driver"

Remove uses of MODULE_DESCRIPTION(), MODULE_AUTHOR(), MODULE_LICENSE(),
etc., so that when reading the driver there is no doubt it is builtin-only.
The information is preserved in comments at the top of the file.

Note that for non-modular code, module_init() translates to
device_initcall().  One could argue that we should use subsys_initcall()
here, but for now we stick with runtime equivalence.

We delete module.h but we keep the moduleparam.h include, since we are
keeping the module_param() that the file has as-is for now.

Signed-off-by: default avatarPaul Gortmaker <paul.gortmaker@windriver.com>
Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
CC: Kristen Carlson Accardi <kristen@linux.intel.com>
parent 57b51b9a

drivers/pci/hotplug/pciehp_core.c

+5 −15
Original line number Diff line number Diff line
@@ -27,7 +27,6 @@ 
 *

 */



#include <linux/module.h>

#include <linux/moduleparam.h>

#include <linux/kernel.h>

#include <linux/slab.h>
@@ -47,10 +46,10 @@ static bool pciehp_force; 
#define DRIVER_AUTHOR	"Dan Zink <dan.zink@compaq.com>, Greg Kroah-Hartman <greg@kroah.com>, Dely Sy <dely.l.sy@intel.com>"

#define DRIVER_DESC	"PCI Express Hot Plug Controller Driver"



MODULE_AUTHOR(DRIVER_AUTHOR);

MODULE_DESCRIPTION(DRIVER_DESC);

MODULE_LICENSE("GPL");



/*

 * not really modular, but the easiest way to keep compat with existing

 * bootargs behaviour is to continue using module_param here.

 */

module_param(pciehp_debug, bool, 0644);

module_param(pciehp_poll_mode, bool, 0644);

module_param(pciehp_poll_time, int, 0644);
@@ -337,13 +336,4 @@ static int __init pcied_init(void) 


	return retval;

}



static void __exit pcied_cleanup(void)

{

	dbg("unload_pciehpd()\n");

	pcie_port_service_unregister(&hpdriver_portdrv);

	info(DRIVER_DESC " version: " DRIVER_VERSION " unloaded\n");

}



module_init(pcied_init);

module_exit(pcied_cleanup);
 
device_initcall(pcied_init);