Commit 6edf1017 authored Oct 23, 2016 by Elad Raz Committed by David S. Miller Oct 26, 2016

devlink: Prevent port_type_set() callback when it's not needed



When a port_type_set() is been called and the new port type set is the same
as the old one, just return success.

Signed-off-by: Elad Raz <eladr@mellanox.com>
Signed-off-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 89ab88b0

net/core/devlink.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -608,6 +608,8 @@ static int devlink_port_type_set(struct devlink *devlink,
		if (devlink->ops && devlink->ops->port_type_set) {
		if (port_type == DEVLINK_PORT_TYPE_NOTSET)
		return -EINVAL;
		if (port_type == devlink_port->type)
		return 0;
		err = devlink->ops->port_type_set(devlink_port, port_type);
		if (err)
		return err;