Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6e9bb530 authored by Andrew Boyer's avatar Andrew Boyer Committed by Doug Ledford
Browse files

IB/rxe: Remove buffer used for printing IP address 



Avoid smashing the stack when an ICRC error occurs on an IPv6 network.

Signed-off-by: default avatarAndrew Boyer <andrew.boyer@dell.com>
Signed-off-by: default avatarDoug Ledford <dledford@redhat.com>
parent 95db9d05

drivers/infiniband/sw/rxe/rxe_recv.c

+5 −6
Original line number Diff line number Diff line
@@ -391,16 +391,15 @@ int rxe_rcv(struct sk_buff *skb) 
			     payload_size(pkt));

	calc_icrc = cpu_to_be32(~calc_icrc);

	if (unlikely(calc_icrc != pack_icrc)) {

		char saddr[sizeof(struct in6_addr)];



		if (skb->protocol == htons(ETH_P_IPV6))

			sprintf(saddr, "%pI6", &ipv6_hdr(skb)->saddr);

			pr_warn_ratelimited("bad ICRC from %pI6c\n",

					    &ipv6_hdr(skb)->saddr);

		else if (skb->protocol == htons(ETH_P_IP))

			sprintf(saddr, "%pI4", &ip_hdr(skb)->saddr);

			pr_warn_ratelimited("bad ICRC from %pI4\n",

					    &ip_hdr(skb)->saddr);

		else

			sprintf(saddr, "unknown");

			pr_warn_ratelimited("bad ICRC from unknown\n");



		pr_warn_ratelimited("bad ICRC from %s\n", saddr);

		goto drop;

	}