Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6d0ec1dd authored by Fabio Estevam's avatar Fabio Estevam Committed by Russell King
Browse files

ARM: 8183/1: l2c: Improve l2c310_of_parse() error message 

Russell King suggested [1]:

"I'd ask for one change.  Please make all these messages start with
"L2C-310 OF" not "PL310 OF:".  The device is described in ARM
documentation as a L2C-310 not PL310.  (Also note the : is dropped
too - most of the other messages don't have the : either.)

The:

"PL310 OF: cache setting yield illegal associativity
PL310 OF: -1073346556 calculated, only 8 and 16 legal"

message could also be changed to something like:

"L2C-310 OF cache associativity %d invalid, only 8 or 16 permittedn"

[1] http://www.spinics.net/lists/arm-kernel/msg372776.html



Signed-off-by: default avatarFabio Estevam <fabio.estevam@freescale.com>
Signed-off-by: default avatarRussell King <rmk+kernel@arm.linux.org.uk>
parent 00575729

arch/arm/mm/cache-l2x0.c

+2 −2
Original line number Diff line number Diff line
@@ -1174,8 +1174,8 @@ static void __init l2c310_of_parse(const struct device_node *np, 
		*aux_mask &= ~L2X0_AUX_CTRL_ASSOC_MASK;

		break;

	default:

		pr_err("PL310 OF: cache setting yield illegal associativity\n");

		pr_err("PL310 OF: %d calculated, only 8 and 16 legal\n", assoc);

		pr_err("L2C-310 OF cache associativity %d invalid, only 8 or 16 permitted\n",

		       assoc);

		break;

	}

}