Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6cad39d5 authored by Sandeep Panda's avatar Sandeep Panda Committed by Gerrit - the friendly Code Review server
Browse files

drm/msm/dsi-staging: improve ESD error logging 



Sometimes during ESD check in driver, the display panel
might return some wrong value which is not captured as
part of failure log. This change improves the same by
printing the panel return value, which will tell what was
the status of panel when issue happened.

Change-Id: I10618dc41b067932ae27a5c60c85565fb136f0ea
Signed-off-by: default avatarSandeep Panda <spanda@codeaurora.org>
parent 043fab3c

drivers/gpu/drm/msm/dsi-staging/dsi_ctrl.c

+2 −2
Original line number Diff line number Diff line
@@ -1496,7 +1496,7 @@ static int dsi_message_rx(struct dsi_ctrl *dsi_ctrl, 
	cmd = buff[0];

	switch (cmd) {

	case MIPI_DSI_RX_ACKNOWLEDGE_AND_ERROR_REPORT:

		pr_err("Rx ACK_ERROR\n");

		pr_err("Rx ACK_ERROR 0x%x\n", cmd);

		rc = 0;

		break;

	case MIPI_DSI_RX_GENERIC_SHORT_READ_RESPONSE_1BYTE:
@@ -1512,7 +1512,7 @@ static int dsi_message_rx(struct dsi_ctrl *dsi_ctrl, 
		rc = dsi_parse_long_read_resp(msg, buff);

		break;

	default:

		pr_warn("Invalid response\n");

		pr_warn("Invalid response: 0x%x\n", cmd);

		rc = 0;

	}

drivers/gpu/drm/msm/dsi-staging/dsi_display.c

+4 −1
Original line number Diff line number Diff line
@@ -577,9 +577,12 @@ static bool dsi_display_validate_reg_read(struct dsi_panel *panel) 
	for (j = 0; j < config->groups; ++j) {

		for (i = 0; i < len; ++i) {

			if (config->return_buf[i] !=

				config->status_value[group + i])

				config->status_value[group + i]) {

				DRM_ERROR("mismatch: 0x%x\n",

					  config->return_buf[i]);

				break;

			}

		}



		if (i == len)

			return true;