Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6c834125 authored by Yun Wu's avatar Yun Wu Committed by Jason Cooper
Browse files

irqchip: gicv3-its: Zero itt before handling to hardware 



Some kind of brain-dead implementations chooses to insert ITEes in
rapid sequence of disabled ITEes, and an un-zeroed ITT will confuse
ITS on judging whether an ITE is really enabled or not. Considering
the implementations are still supported by the GICv3 architecture,
in which ITT is not required to be zeroed before being handled to
hardware, we do the favor in ITS driver.

Acked-by: default avatarMarc Zyngier <marc.zyngier@arm.com>
Signed-off-by: default avatarYun Wu <wuyun.wu@huawei.com>
Signed-off-by: default avatarMarc Zyngier <marc.zyngier@arm.com>
Link: https://lkml.kernel.org/r/1425659870-11832-8-git-send-email-marc.zyngier@arm.com


Signed-off-by: default avatarJason Cooper <jason@lakedaemon.net>
parent 614be385

drivers/irqchip/irq-gic-v3-its.c

+1 −1
Original line number Original line Diff line number Diff line
@@ -1076,7 +1076,7 @@ static struct its_device *its_create_device(struct its_node *its, u32 dev_id, 
	nr_ites = max(2UL, roundup_pow_of_two(nvecs));

	nr_ites = max(2UL, roundup_pow_of_two(nvecs));

	sz = nr_ites * its->ite_size;

	sz = nr_ites * its->ite_size;

	sz = max(sz, ITS_ITT_ALIGN) + ITS_ITT_ALIGN - 1;

	sz = max(sz, ITS_ITT_ALIGN) + ITS_ITT_ALIGN - 1;

	itt = kmalloc(sz, GFP_KERNEL);

	itt = kzalloc(sz, GFP_KERNEL);

	lpi_map = its_lpi_alloc_chunks(nvecs, &lpi_base, &nr_lpis);

	lpi_map = its_lpi_alloc_chunks(nvecs, &lpi_base, &nr_lpis);





	if (!dev || !itt || !lpi_map) {

	if (!dev || !itt || !lpi_map) {