Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6c53694f authored by Dmitry Torokhov's avatar Dmitry Torokhov
Browse files

Input: synaptics - split device info into a separate structure 



In preparation for SMBus/Intertouch device support, move static device
information that we query form the touchpad upon initialization into
separate structure. This will allow us to query the device without
allocating memory first.

Also stop using "unsigned long", everything fits into 32 bit chunks.

Reviewed-by: default avatarBenjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: default avatarDmitry Torokhov <dmitry.torokhov@gmail.com>
parent 8eb92e5c

drivers/input/mouse/synaptics.c

+217 −175

File changed.

Preview size limit exceeded, changes collapsed.

drivers/input/mouse/synaptics.h

+16 −12
Original line number Diff line number Diff line
@@ -161,19 +161,23 @@ struct synaptics_hw_state { 
	signed char scroll;

};



struct synaptics_data {

/* Data read from the touchpad */

	unsigned long int model_id;		/* Model-ID */

	unsigned long int firmware_id;		/* Firmware-ID */

	unsigned long int board_id;		/* Board-ID */

	unsigned long int capabilities;		/* Capabilities */

	unsigned long int ext_cap;		/* Extended Capabilities */

	unsigned long int ext_cap_0c;		/* Ext Caps from 0x0c query */

	unsigned long int ext_cap_10;		/* Ext Caps from 0x10 query */

	unsigned long int identity;		/* Identification */

	unsigned int x_res, y_res;		/* X/Y resolution in units/mm */

	unsigned int x_max, y_max;		/* Max coordinates (from FW) */

	unsigned int x_min, y_min;		/* Min coordinates (from FW) */

struct synaptics_device_info {

	u32 model_id;		/* Model-ID */

	u32 firmware_id;	/* Firmware-ID */

	u32 board_id;		/* Board-ID */

	u32 capabilities;	/* Capabilities */

	u32 ext_cap;		/* Extended Capabilities */

	u32 ext_cap_0c;		/* Ext Caps from 0x0c query */

	u32 ext_cap_10;		/* Ext Caps from 0x10 query */

	u32 identity;		/* Identification */

	u32 x_res, y_res;	/* X/Y resolution in units/mm */

	u32 x_max, y_max;	/* Max coordinates (from FW) */

	u32 x_min, y_min;	/* Min coordinates (from FW) */

};



struct synaptics_data {

	struct synaptics_device_info info;



	unsigned char pkt_type;			/* packet type - old, new, etc */

	unsigned char mode;			/* current mode byte */