Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6c4c82e2 authored by Milton Miller's avatar Milton Miller Committed by Benjamin Herrenschmidt
Browse files

powerpc/fsl_msi: Don't abuse platform_data for driver_data 



The msi platform device driver was abusing dev.platform_data for its
platform_driver_data.  Use the correct pointer for storage.

Platform_data is supposed to be for platforms to communicate to drivers
parameters that are not otherwise discoverable.  Its lifetime matches
the platform_device not the platform device driver.  It is generally
not needed for drivers that only support systems with device trees.

Signed-off-by: default avatarMilton Miller <miltonm@bga.com>
Acked-by: default avatarGrant Likely <grant.likely@secretlab.ca>
Signed-off-by: default avatarBenjamin Herrenschmidt <benh@kernel.crashing.org>
parent 7ee342bd

arch/powerpc/sysdev/fsl_msi.c

+2 −2
Original line number Diff line number Diff line
@@ -253,7 +253,7 @@ static void fsl_msi_cascade(unsigned int irq, struct irq_desc *desc) 


static int fsl_of_msi_remove(struct platform_device *ofdev)

{

	struct fsl_msi *msi = ofdev->dev.platform_data;

	struct fsl_msi *msi = platform_get_drvdata(ofdev);

	int virq, i;

	struct fsl_msi_cascade_data *cascade_data;
@@ -327,7 +327,7 @@ static int __devinit fsl_of_msi_probe(struct platform_device *dev) 
		dev_err(&dev->dev, "No memory for MSI structure\n");

		return -ENOMEM;

	}

	dev->dev.platform_data = msi;

	platform_set_drvdata(dev, msi);



	msi->irqhost = irq_alloc_host(dev->dev.of_node, IRQ_HOST_MAP_LINEAR,

				      NR_MSI_IRQS, &fsl_msi_host_ops, 0);