Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6bedb2cc authored by Oleg Nesterov's avatar Oleg Nesterov Committed by Andi Kleen
Browse files

[PATCH] x86-64: don't use set_irq_regs() 



We don't need to setup _irq_regs in smp_xxx_interrupt (except apic timer).
These handlers run with irqs disabled and do not call functions which need
"struct pt_regs".

Signed-off-by: default avatarOleg Nesterov <oleg@tv-sign.ru>
Signed-off-by: default avatarAndi Kleen <ak@suse.de>
Acked-by: default avatarIngo Molnar <mingo@elte.hu>
Cc: Andi Kleen <ak@suse.de>
Acked-By: default avatarDavid Howells <dhowells@redhat.com>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
parent ad892f5e

arch/i386/kernel/smp.c

+0 −6
Original line number Diff line number Diff line
@@ -321,7 +321,6 @@ static inline void leave_mm (unsigned long cpu) 


fastcall void smp_invalidate_interrupt(struct pt_regs *regs)

{

	struct pt_regs *old_regs = set_irq_regs(regs);

	unsigned long cpu;



	cpu = get_cpu();
@@ -352,7 +351,6 @@ fastcall void smp_invalidate_interrupt(struct pt_regs *regs) 
	smp_mb__after_clear_bit();

out:

	put_cpu_no_resched();

	set_irq_regs(old_regs);

}



static void flush_tlb_others(cpumask_t cpumask, struct mm_struct *mm,
@@ -607,14 +605,11 @@ void smp_send_stop(void) 
 */

fastcall void smp_reschedule_interrupt(struct pt_regs *regs)

{

	struct pt_regs *old_regs = set_irq_regs(regs);

	ack_APIC_irq();

	set_irq_regs(old_regs);

}



fastcall void smp_call_function_interrupt(struct pt_regs *regs)

{

	struct pt_regs *old_regs = set_irq_regs(regs);

	void (*func) (void *info) = call_data->func;

	void *info = call_data->info;

	int wait = call_data->wait;
@@ -637,7 +632,6 @@ fastcall void smp_call_function_interrupt(struct pt_regs *regs) 
		mb();

		atomic_inc(&call_data->finished);

	}

	set_irq_regs(old_regs);

}



/*