Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6b101116 authored by Guenter Roeck's avatar Guenter Roeck Committed by Jean Delvare
Browse files

hwmon: (lm90) Add range check to set_update_interval 



When writing the update_interval attribute, the parameter value was
not range checked, which could cause an integer overflow and result
in an arbitrary update interval. Fix by limiting the value range to
<0, 100000>.

Reported-by: default avatarJean Delvare <khali@linux-fr.org>
Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
Signed-off-by: default avatarJean Delvare <khali@linux-fr.org>
parent 2fe28ab5

drivers/hwmon/lm90.c

+1 −1
Original line number Diff line number Diff line
@@ -917,7 +917,7 @@ static ssize_t set_update_interval(struct device *dev, 
		return err;



	mutex_lock(&data->update_lock);

	lm90_set_convrate(client, data, val);

	lm90_set_convrate(client, data, SENSORS_LIMIT(val, 0, 100000));

	mutex_unlock(&data->update_lock);



	return count;