Commit 6a934bb8 authored Aug 23, 2017 by Bart Van Assche Committed by Jens Axboe Aug 24, 2017

compat_hdio_ioctl: Fix a declaration

This patch avoids that sparse reports the following warning messages:

block/compat_ioctl.c:85:11: warning: incorrect type in assignment (different address spaces)
block/compat_ioctl.c:85:11: expected unsigned long *[noderef] <asn:1>p
block/compat_ioctl.c:85:11: got void [noderef] <asn:1>*
block/compat_ioctl.c:91:21: warning: incorrect type in argument 1 (different address spaces)
block/compat_ioctl.c:91:21: expected void const volatile [noderef] <asn:1>*<noident>
block/compat_ioctl.c:91:21: got unsigned long *[noderef] <asn:1>p
block/compat_ioctl.c:87:53: warning: dereference of noderef expression
block/compat_ioctl.c:91:21: warning: dereference of noderef expression

Fixes: commit d597580d ("generic ...copy_..._user primitives")
Signed-off-by: Bart Van Assche <bart.vanassche@wdc.com>
Cc: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Jens Axboe <axboe@kernel.dk>

parent 47570848

block/compat_ioctl.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -79,7 +79,7 @@ static int compat_hdio_getgeo(struct gendisk disk, struct block_device bdev,
	static int compat_hdio_ioctl(struct block_device *bdev, fmode_t mode,		static int compat_hdio_ioctl(struct block_device *bdev, fmode_t mode,
	unsigned int cmd, unsigned long arg)		unsigned int cmd, unsigned long arg)
	{		{
	unsigned long *__user p;		unsigned long __user *p;
	int error;		int error;

	p = compat_alloc_user_space(sizeof(unsigned long));		p = compat_alloc_user_space(sizeof(unsigned long));