Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6a258f7d authored by Colin Ian King's avatar Colin Ian King Committed by Richard Weinberger
Browse files

ubifs: Fix cut and paste error on sb type comparisons 



The check for the bad node type of sb->type is checking sa->type
and not sb-type. This looks like a cut and paste error. Fix this.

Detected by PVS-Studio, warning: V581

Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Signed-off-by: default avatarRichard Weinberger <richard@nod.at>
parent 8a143588

fs/ubifs/debug.c

+2 −2
Original line number Diff line number Diff line
@@ -2391,8 +2391,8 @@ int dbg_check_nondata_nodes_order(struct ubifs_info *c, struct list_head *head) 
			ubifs_dump_node(c, sa->node);

			return -EINVAL;

		}

		if (sa->type != UBIFS_INO_NODE && sa->type != UBIFS_DENT_NODE &&

		    sa->type != UBIFS_XENT_NODE) {

		if (sb->type != UBIFS_INO_NODE && sb->type != UBIFS_DENT_NODE &&

		    sb->type != UBIFS_XENT_NODE) {

			ubifs_err(c, "bad node type %d", sb->type);

			ubifs_dump_node(c, sb->node);

			return -EINVAL;