Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 690e781c authored by Dan Carpenter's avatar Dan Carpenter Committed by John W. Linville
Browse files

ath9k_htc: dereferencing before check in hif_usb_tx_cb() 



After c11d8f89: "ath9k_htc: Simplify TX URB management" we no longer
assume that tx_buf is a non-null pointer.

Signed-off-by: default avatarDan Carpenter <error27@gmail.com>
Acked-by: default avatarSujith <Sujith.Manoharan@atheros.com>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent 663cb47c

drivers/net/wireless/ath/ath9k/hif_usb.c

+4 −2
Original line number Diff line number Diff line
@@ -107,12 +107,14 @@ static inline void ath9k_skb_queue_purge(struct hif_device_usb *hif_dev, 
static void hif_usb_tx_cb(struct urb *urb)

{

	struct tx_buf *tx_buf = (struct tx_buf *) urb->context;

	struct hif_device_usb *hif_dev = tx_buf->hif_dev;

	struct hif_device_usb *hif_dev;

	struct sk_buff *skb;



	if (!hif_dev || !tx_buf)

	if (!tx_buf || !tx_buf->hif_dev)

		return;



	hif_dev = tx_buf->hif_dev;



	switch (urb->status) {

	case 0:

		break;