Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6860f9ca authored by Mauro Carvalho Chehab's avatar Mauro Carvalho Chehab
Browse files

[media] mantis: get rid of warning: no previous prototype 



drivers/media/pci/mantis/mantis_input.c:107:5: warning: no previous prototype for 'mantis_input_init' [-Wmissing-prototypes]
drivers/media/pci/mantis/mantis_input.c:153:5: warning: no previous prototype for 'mantis_exit' [-Wmissing-prototypes]
drivers/media/pci/mantis/mantis_uart.c:64:5: warning: no previous prototype for 'mantis_uart_read' [-Wmissing-prototypes]
drivers/media/pci/mantis/mantis_vp1033.c:118:5: warning: no previous prototype for 'lgtdqcs001f_set_symbol_rate' [-Wmissing-prototypes]
drivers/media/pci/mantis/mantis_vp1033.c:86:5: warning: no previous prototype for 'lgtdqcs001f_tuner_set' [-Wmissing-prototypes]

Note: there is already a mantis_exit at the mantis driver. So,
this should be renamed to mantis_input_exit.

The mantis_input code is currently unused, as it doesn't implement the RC API
right.

Patches for it are sent for discussions, but were never
accepted. So, while this is not fixed, the entire code inside
mantis_input can simply be commented.

Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent d6eb0b99

drivers/media/pci/mantis/mantis_input.c

+4 −1
Original line number Original line Diff line number Diff line
@@ -18,6 +18,8 @@ 
	Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.

	Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.

*/

*/





#if 0 /* Currently unused */



#include <media/rc-core.h>

#include <media/rc-core.h>

#include <linux/pci.h>

#include <linux/pci.h>
@@ -150,10 +152,11 @@ int mantis_input_init(struct mantis_pci *mantis) 
	return err;

	return err;

}

}





int mantis_exit(struct mantis_pci *mantis)

int mantis_init_exit(struct mantis_pci *mantis)

{

{

	rc_unregister_device(mantis->rc);

	rc_unregister_device(mantis->rc);

	rc_map_unregister(&ir_mantis_map);

	rc_map_unregister(&ir_mantis_map);

	return 0;

	return 0;

}

}





#endif

drivers/media/pci/mantis/mantis_uart.c

+1 −1
Original line number Original line Diff line number Diff line
@@ -61,7 +61,7 @@ static struct { 




#define UART_MAX_BUF			16

#define UART_MAX_BUF			16





int mantis_uart_read(struct mantis_pci *mantis, u8 *data)

static int mantis_uart_read(struct mantis_pci *mantis, u8 *data)

{

{

	struct mantis_hwconfig *config = mantis->hwconfig;

	struct mantis_hwconfig *config = mantis->hwconfig;

	u32 stat = 0, i;

	u32 stat = 0, i;

drivers/media/pci/mantis/mantis_vp1033.c

+3 −3
Original line number Original line Diff line number Diff line
@@ -83,7 +83,7 @@ u8 lgtdqcs001f_inittab[] = { 
#define MANTIS_MODEL_NAME	"VP-1033"

#define MANTIS_MODEL_NAME	"VP-1033"

#define MANTIS_DEV_TYPE		"DVB-S/DSS"

#define MANTIS_DEV_TYPE		"DVB-S/DSS"





int lgtdqcs001f_tuner_set(struct dvb_frontend *fe)

static int lgtdqcs001f_tuner_set(struct dvb_frontend *fe)

{

{

	struct dtv_frontend_properties *p = &fe->dtv_property_cache;

	struct dtv_frontend_properties *p = &fe->dtv_property_cache;

	struct mantis_pci *mantis	= fe->dvb->priv;

	struct mantis_pci *mantis	= fe->dvb->priv;
@@ -115,7 +115,7 @@ int lgtdqcs001f_tuner_set(struct dvb_frontend *fe) 
	return 0;

	return 0;

}

}





int lgtdqcs001f_set_symbol_rate(struct dvb_frontend *fe,

static int lgtdqcs001f_set_symbol_rate(struct dvb_frontend *fe,

				       u32 srate, u32 ratio)

				       u32 srate, u32 ratio)

{

{

	u8 aclk = 0;

	u8 aclk = 0;