Commit 67bc3f42 authored Mar 01, 2016 by Wolfram Sang Committed by Eduardo Valentin Mar 08, 2016

thermal: rcar_thermal: don't open code of_device_get_match_data()



This change will also make Coverity happy by avoiding a theoretical NULL
pointer dereference; yet another reason is to use the above helper function
to tighten the code and make it more readable.

Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Signed-off-by: Eduardo Valentin <edubezval@gmail.com>

parent 527860fe

drivers/thermal/rcar_thermal.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -430,8 +430,7 @@ static int rcar_thermal_probe(struct platform_device *pdev)
		struct rcar_thermal_priv *priv;
		struct device *dev = &pdev->dev;
		struct resource res, irq;
		const struct of_device_id *of_id = of_match_device(rcar_thermal_dt_ids, dev);
		unsigned long of_data = (unsigned long)of_id->data;
		unsigned long of_data = (unsigned long)of_device_get_match_data(dev);
		int mres = 0;
		int i;
		int ret = -ENODEV;