Commit 676121fc authored Jan 08, 2006 by Ben Collins Committed by Linus Torvalds Jan 08, 2006

[PATCH] Unchecked alloc_percpu() return in __create_workqueue()



__create_workqueue() not checking return of alloc_percpu()

NULL dereference was possible.

Signed-off-by: Ben Collins <bcollins@ubuntu.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

parent 9fa37fd1

kernel/workqueue.c

+5 −0

Original line number	Diff line number	Diff line
		@@ -315,6 +315,11 @@ struct workqueue_struct __create_workqueue(const char name,
		return NULL;

		wq->cpu_wq = alloc_percpu(struct cpu_workqueue_struct);
		if (!wq->cpu_wq) {
		kfree(wq);
		return NULL;
		}

		wq->name = name;
		/* We don't need the distraction of CPUs appearing and vanishing. */
		lock_cpu_hotplug();