Commit 670e3fef authored Mar 21, 2016 by Bhaktipriya Shridhar Committed by Greg Kroah-Hartman Mar 28, 2016

staging: rtl8712: rtl871x_mlme: Clean up tests if NULL returned on failure



Some functions like kmalloc/kzalloc return NULL on failure.
When NULL represents failure, !x is commonly used.

This was done using Coccinelle:

@@
expression *e;
identifier l1;
@@

e = \(kmalloc\|kzalloc\|kcalloc\|devm_kzalloc\)(...);
...
- e == NULL
+ !e

Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent ddf6451f

drivers/staging/rtl8712/rtl871x_mlme.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -1205,7 +1205,7 @@ sint r8712_set_auth(struct _adapter *adapter,
		return _FAIL;

		psetauthparm = kzalloc(sizeof(*psetauthparm), GFP_ATOMIC);
		if (psetauthparm == NULL) {
		if (!psetauthparm) {
		kfree(pcmd);
		return _FAIL;
		}
		@@ -1234,7 +1234,7 @@ sint r8712_set_key(struct _adapter *adapter,
		if (!pcmd)
		return _FAIL;
		psetkeyparm = kzalloc(sizeof(*psetkeyparm), GFP_ATOMIC);
		if (psetkeyparm == NULL) {
		if (!psetkeyparm) {
		ret = _FAIL;
		goto err_free_cmd;
		}