Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 644e0840 authored by Adrian Hunter's avatar Adrian Hunter Committed by Arnaldo Carvalho de Melo
Browse files

perf auxtrace: Add CPU filter support 



Decoding auxtrace data can take a long time. To avoid decoding
unnecessarily, filter auxtrace data that is collected per-cpu before it is
decoded.

Signed-off-by: default avatarAdrian Hunter <adrian.hunter@intel.com>
Cc: Andi Kleen <ak@linux.intel.com>
Link: http://lkml.kernel.org/r/1495786658-18063-38-git-send-email-adrian.hunter@intel.com


Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent 38b65b08

tools/perf/builtin-report.c

+1 −0
Original line number Diff line number Diff line
@@ -557,6 +557,7 @@ static int __cmd_report(struct report *rep) 
			ui__error("failed to set cpu bitmap\n");

			return ret;

		}

		session->itrace_synth_opts->cpu_bitmap = rep->cpu_bitmap;

	}



	if (rep->show_threads) {

tools/perf/builtin-script.c

+1 −0
Original line number Diff line number Diff line
@@ -2992,6 +2992,7 @@ int cmd_script(int argc, const char **argv) 
		err = perf_session__cpu_bitmap(session, cpu_list, cpu_bitmap);

		if (err < 0)

			goto out_delete;

		itrace_synth_opts.cpu_bitmap = cpu_bitmap;

	}



	if (!no_callchain)

tools/perf/util/auxtrace.c

+10 −0
Original line number Diff line number Diff line
@@ -322,6 +322,13 @@ static int auxtrace_queues__add_event_buffer(struct auxtrace_queues *queues, 
	return auxtrace_queues__add_buffer(queues, idx, buffer);

}



static bool filter_cpu(struct perf_session *session, int cpu)

{

	unsigned long *cpu_bitmap = session->itrace_synth_opts->cpu_bitmap;



	return cpu_bitmap && cpu != -1 && !test_bit(cpu, cpu_bitmap);

}



int auxtrace_queues__add_event(struct auxtrace_queues *queues,

			       struct perf_session *session,

			       union perf_event *event, off_t data_offset,
@@ -331,6 +338,9 @@ int auxtrace_queues__add_event(struct auxtrace_queues *queues, 
	unsigned int idx;

	int err;



	if (filter_cpu(session, event->auxtrace.cpu))

		return 0;



	buffer = zalloc(sizeof(struct auxtrace_buffer));

	if (!buffer)

		return -ENOMEM;

tools/perf/util/auxtrace.h

+2 −0
Original line number Diff line number Diff line
@@ -74,6 +74,7 @@ enum itrace_period_type { 
 * @period: 'instructions' events period

 * @period_type: 'instructions' events period type

 * @initial_skip: skip N events at the beginning.

 * @cpu_bitmap: CPUs for which to synthesize events, or NULL for all

 */

struct itrace_synth_opts {

	bool			set;
@@ -96,6 +97,7 @@ struct itrace_synth_opts { 
	unsigned long long	period;

	enum itrace_period_type	period_type;

	unsigned long		initial_skip;

	unsigned long		*cpu_bitmap;

};



/**