Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 63ea3749 authored by Dan Carpenter's avatar Dan Carpenter Committed by Roland Dreier
Browse files

RDMA/ocrdma: Fix several stack info leaks 



A grab bag of places which don't properly initialize stack data.  I
removed one place which cleared ".rsvd" because it's not needed now
that I have added a memset() earlier in the function.

Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarRoland Dreier <roland@purestorage.com>
parent 3606b999

drivers/infiniband/hw/ocrdma/ocrdma_verbs.c

+4 −1
Original line number Diff line number Diff line
@@ -242,6 +242,7 @@ struct ib_ucontext *ocrdma_alloc_ucontext(struct ib_device *ibdev, 
	memset(ctx->ah_tbl.va, 0, map_len);

	ctx->ah_tbl.len = map_len;



	memset(&resp, 0, sizeof(resp));

	resp.ah_tbl_len = ctx->ah_tbl.len;

	resp.ah_tbl_page = ctx->ah_tbl.pa;
@@ -253,7 +254,6 @@ struct ib_ucontext *ocrdma_alloc_ucontext(struct ib_device *ibdev, 
	resp.wqe_size = dev->attr.wqe_size;

	resp.rqe_size = dev->attr.rqe_size;

	resp.dpp_wqe_size = dev->attr.wqe_size;

	resp.rsvd = 0;



	memcpy(resp.fw_ver, dev->attr.fw_ver, sizeof(resp.fw_ver));

	status = ib_copy_to_udata(udata, &resp, sizeof(resp));
@@ -338,6 +338,7 @@ static int ocrdma_copy_pd_uresp(struct ocrdma_pd *pd, 
	struct ocrdma_alloc_pd_uresp rsp;

	struct ocrdma_ucontext *uctx = get_ocrdma_ucontext(ib_ctx);



	memset(&rsp, 0, sizeof(rsp));

	rsp.id = pd->id;

	rsp.dpp_enabled = pd->dpp_enabled;

	db_page_addr = pd->dev->nic_info.unmapped_db +
@@ -692,6 +693,7 @@ static int ocrdma_copy_cq_uresp(struct ocrdma_cq *cq, struct ib_udata *udata, 
	struct ocrdma_ucontext *uctx;

	struct ocrdma_create_cq_uresp uresp;



	memset(&uresp, 0, sizeof(uresp));

	uresp.cq_id = cq->id;

	uresp.page_size = cq->len;

	uresp.num_pages = 1;
@@ -1460,6 +1462,7 @@ static int ocrdma_copy_srq_uresp(struct ocrdma_srq *srq, struct ib_udata *udata) 
	int status;

	struct ocrdma_create_srq_uresp uresp;



	memset(&uresp, 0, sizeof(uresp));

	uresp.rq_dbid = srq->rq.dbid;

	uresp.num_rq_pages = 1;

	uresp.rq_page_addr[0] = srq->rq.pa;