Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 63bb4d78 authored by Alexey Khoroshilov's avatar Alexey Khoroshilov Committed by Greg Kroah-Hartman
Browse files

video: clps711x-fb: release disp device node in probe() 



[ Upstream commit fdac751355cd76e049f628afe6acb8ff4b1399f7 ]

clps711x_fb_probe() increments refcnt of disp device node by
of_parse_phandle() and leaves it undecremented on both
successful and error paths.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: default avatarAlexey Khoroshilov <khoroshilov@ispras.ru>
Cc: Alexander Shiyan <shc_work@mail.ru>
Signed-off-by: default avatarBartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 46341255

drivers/video/fbdev/clps711x-fb.c

+4 −1
Original line number Diff line number Diff line
@@ -287,14 +287,17 @@ static int clps711x_fb_probe(struct platform_device *pdev) 
	}



	ret = of_get_fb_videomode(disp, &cfb->mode, OF_USE_NATIVE_MODE);

	if (ret)

	if (ret) {

		of_node_put(disp);

		goto out_fb_release;

	}



	of_property_read_u32(disp, "ac-prescale", &cfb->ac_prescale);

	cfb->cmap_invert = of_property_read_bool(disp, "cmap-invert");



	ret = of_property_read_u32(disp, "bits-per-pixel",

				   &info->var.bits_per_pixel);

	of_node_put(disp);

	if (ret)

		goto out_fb_release;