Commit 62867d49 authored Jun 21, 2012 by Guenter Roeck

hwmon: (fam15h_power) Fix unintentional integer overflow

Expression with two unsigned integer variables is calculated as unsigned integer
before it is converted to u64. This may result in an integer overflow.
Fix by typecasting the left operand to u64 before performing the left shift.

This patch addresses Coverity #402320: Unintentional integer overflow.

Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Acked-by: Jean Delvare <khali@linux-fr.org>
Acked-by: Andreas Herrmann <andreas.herrmann3@amd.com>

parent 58c3667d

drivers/hwmon/fam15h_power.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -67,7 +67,8 @@ static ssize_t show_power(struct device *dev,
		REG_TDP_LIMIT3, &val);

		tdp_limit = val >> 16;
		curr_pwr_watts = (tdp_limit + data->base_tdp) << running_avg_range;
		curr_pwr_watts = ((u64)(tdp_limit +
		data->base_tdp)) << running_avg_range;
		curr_pwr_watts -= running_avg_capture;
		curr_pwr_watts *= data->tdp_to_watts;