Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5ee22a5a authored by Ron Mercer's avatar Ron Mercer Committed by David S. Miller
Browse files

qlge: Fix queueing of firmware handler in ISR. 



Check that we are not already polling firmware events before we queue the
firmware event worker, then disable firmware interrupts.
Otherwise we can queue the same event multiple times.

Signed-off-by: default avatarRon Mercer <ron.mercer@qlogic.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent d799bbfb

drivers/net/qlge/qlge_main.c

+5 −3
Original line number Diff line number Diff line
@@ -2001,15 +2001,17 @@ static irqreturn_t qlge_isr(int irq, void *dev_id) 
	/*

	 * Check MPI processor activity.

	 */

	if (var & STS_PI) {

	if ((var & STS_PI) &&

		(ql_read32(qdev, INTR_MASK) & INTR_MASK_PI)) {

		/*

		 * We've got an async event or mailbox completion.

		 * Handle it and clear the source of the interrupt.

		 */

		QPRINTK(qdev, INTR, ERR, "Got MPI processor interrupt.\n");

		ql_disable_completion_interrupt(qdev, intr_context->intr);

		queue_delayed_work_on(smp_processor_id(), qdev->workqueue,

				      &qdev->mpi_work, 0);

		ql_write32(qdev, INTR_MASK, (INTR_MASK_PI << 16));

		queue_delayed_work_on(smp_processor_id(),

				qdev->workqueue, &qdev->mpi_work, 0);

		work_done++;

	}