Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5ec467a8 authored by Wei Yongjun's avatar Wei Yongjun Committed by Dave Airlie
Browse files

drm/rcar-du: Fix return value check in rcar_du_lvdsenc_get_resources() 



In case of error, the function devm_ioremap_resource() returns ERR_PTR()
and never returns NULL. The NULL test in the return value check should be
replaced with IS_ERR(). Also remove the dev_err call to avoid redundant
error message.

Signed-off-by: default avatarWei Yongjun <yongjun_wei@trendmicro.com.cn>
[Remove the unneeded mem == NULL check]
Signed-off-by: default avatarLaurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Signed-off-by: default avatarDave Airlie <airlied@redhat.com>
parent 6b27f7f0

drivers/gpu/drm/rcar-du/rcar_du_lvdsenc.c

+2 −11
Original line number Diff line number Diff line
@@ -144,18 +144,9 @@ static int rcar_du_lvdsenc_get_resources(struct rcar_du_lvdsenc *lvds, 
	sprintf(name, "lvds.%u", lvds->index);



	mem = platform_get_resource_byname(pdev, IORESOURCE_MEM, name);

	if (mem == NULL) {

		dev_err(&pdev->dev, "failed to get memory resource for %s\n",

			name);

		return -EINVAL;

	}



	lvds->mmio = devm_ioremap_resource(&pdev->dev, mem);

	if (lvds->mmio == NULL) {

		dev_err(&pdev->dev, "failed to remap memory resource for %s\n",

			name);

		return -ENOMEM;

	}

	if (IS_ERR(lvds->mmio))

		return PTR_ERR(lvds->mmio);



	lvds->clock = devm_clk_get(&pdev->dev, name);

	if (IS_ERR(lvds->clock)) {