Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5e45e500 authored by Tharun Kumar Merugu's avatar Tharun Kumar Merugu
Browse files

msm: adsprpc: Add error handling checks 



Add null pointer check and VERIFY statement for error handling.

Change-Id: Ie51fddd4e279de0246b3b45fe0a947fe5ebb96c3
Acked-by: default avatarMaitreyi Gupta <maitreyi@qti.qualcomm.com>
Signed-off-by: default avatarTharun Kumar Merugu <mtharu@codeaurora.org>
parent 53a55fb7

drivers/char/adsprpc.c

+7 −4
Original line number Diff line number Diff line
@@ -1429,10 +1429,12 @@ static int get_args(uint32_t kernel, struct smq_invoke_ctx *ctx) 


		mutex_lock(&ctx->fl->map_mutex);

		if (ctx->fds && (ctx->fds[i] != -1))

			fastrpc_mmap_create(ctx->fl, ctx->fds[i],

			err = fastrpc_mmap_create(ctx->fl, ctx->fds[i],

					ctx->attrs[i], buf, len,

					mflags, &ctx->maps[i]);

		mutex_unlock(&ctx->fl->map_mutex);

		if (err)

			goto bail;

		ipage += 1;

	}

	PERF_END);
@@ -1443,9 +1445,10 @@ static int get_args(uint32_t kernel, struct smq_invoke_ctx *ctx) 


		if (ctx->attrs && (ctx->attrs[i] & FASTRPC_ATTR_NOMAP))

			dmaflags = FASTRPC_DMAHANDLE_NOMAP;

		VERIFY(err, !fastrpc_mmap_create(ctx->fl, ctx->fds[i],

		if (ctx->fds && (ctx->fds[i] != -1))

			err = fastrpc_mmap_create(ctx->fl, ctx->fds[i],

					FASTRPC_ATTR_NOVA, 0, 0, dmaflags,

				&ctx->maps[i]));

					&ctx->maps[i]);

		if (err) {

			mutex_unlock(&ctx->fl->map_mutex);

			goto bail;