Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5d4121c0 authored by Jiri Slaby's avatar Jiri Slaby Committed by Greg Kroah-Hartman
Browse files

TTY: check if tty->port is assigned 



And if not, complain loudly. None in-kernel module should trigger
that, but let us find out for sure. On the other hand, all the
out-of-tree modules will hit that. Give them some time (maybe one
release) to catch up.

Signed-off-by: default avatarJiri Slaby <jslaby@suse.cz>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 63d48696

drivers/tty/tty_io.c

+4 −0
Original line number Original line Diff line number Diff line
@@ -1415,6 +1415,10 @@ struct tty_struct *tty_init_dev(struct tty_driver *driver, int idx) 
	if (!tty->port)

	if (!tty->port)

		tty->port = driver->ports[idx];

		tty->port = driver->ports[idx];





	WARN_RATELIMIT(!tty->port,

			"%s: %s driver does not set tty->port. This will crash the kernel later. Fix the driver!\n",

			__func__, tty->driver->name);



	/*

	/*

	 * Structures all installed ... call the ldisc open routines.

	 * Structures all installed ... call the ldisc open routines.

	 * If we fail here just call release_tty to clean up.  No need

	 * If we fail here just call release_tty to clean up.  No need