Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5cddd5de authored by Jingoo Han's avatar Jingoo Han Committed by Lee Jones
Browse files

mfd: pm8921: Remove unnecessary platform_set_drvdata() 



The driver core clears the driver data to NULL after device_release
or on probe failure, since commit 0998d063
(device-core: Ensure drvdata = NULL when no driver is bound).
Thus, it is not needed to manually clear the device driver data to NULL.

Signed-off-by: default avatarJingoo Han <jg1.han@samsung.com>
Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
parent ef310f4b

drivers/mfd/pm8921-core.c

+0 −2
Original line number Original line Diff line number Diff line
@@ -160,7 +160,6 @@ static int pm8921_probe(struct platform_device *pdev) 




err:

err:

	mfd_remove_devices(pmic->dev);

	mfd_remove_devices(pmic->dev);

	platform_set_drvdata(pdev, NULL);

err_read_rev:

err_read_rev:

	kfree(pmic);

	kfree(pmic);

	return rc;

	return rc;
@@ -180,7 +179,6 @@ static int pm8921_remove(struct platform_device *pdev) 
		pm8xxx_irq_exit(pmic->irq_chip);

		pm8xxx_irq_exit(pmic->irq_chip);

		pmic->irq_chip = NULL;

		pmic->irq_chip = NULL;

	}

	}

	platform_set_drvdata(pdev, NULL);

	kfree(pmic);

	kfree(pmic);





	return 0;

	return 0;