Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5c788a69 authored by Jesse Barnes's avatar Jesse Barnes
Browse files

PCI: ibmphp_hpc: don't release hw sem twice if kthread stops 



If we stop the kthread, we may end up up'ing the sem twice, which seems
unintended.

Reported-by: default avatarDan Carpenter <error27@gmail.com>
Signed-off-by: default avatarJesse Barnes <jbarnes@virtuousgeek.org>
parent f6e1d8cc

drivers/pci/hotplug/ibmphp_hpc.c

+2 −1
Original line number Original line Diff line number Diff line
@@ -890,7 +890,7 @@ static int poll_hpc(void *data) 
			msleep(POLL_INTERVAL_SEC * 1000);

			msleep(POLL_INTERVAL_SEC * 1000);





			if (kthread_should_stop())

			if (kthread_should_stop())

				break;

				goto out_sleep;

			

			

			down (&semOperations);

			down (&semOperations);
@@ -904,6 +904,7 @@ static int poll_hpc(void *data) 
		/* give up the hardware semaphore */

		/* give up the hardware semaphore */

		up (&semOperations);

		up (&semOperations);

		/* sleep for a short time just for good measure */

		/* sleep for a short time just for good measure */

out_sleep:

		msleep(100);

		msleep(100);

	}

	}

	up (&sem_exit);

	up (&sem_exit);