Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5c461e8e authored by Michał Kępień's avatar Michał Kępień Committed by Darren Hart
Browse files

platform/x86: fujitsu-laptop: simplify logolamp_get() 



Now that call_fext_func() is invoked by logolamp_set() for both
LOGOLAMP_POWERON and LOGOLAMP_ALWAYS for every brightness value,
logolamp_get() can be simplified to decrease indentation and number of
local variables.

Signed-off-by: default avatarMichał Kępień <kernel@kempniu.pl>
Acked-by: default avatarJonathan Woithe <jwoithe@just42.net>
Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
parent dcb50b35

drivers/platform/x86/fujitsu-laptop.c

+11 −11
Original line number Diff line number Diff line
@@ -319,17 +319,17 @@ static int eco_led_set(struct led_classdev *cdev, 


static enum led_brightness logolamp_get(struct led_classdev *cdev)

{

	enum led_brightness brightness = LED_OFF;

	int poweron, always;

	int ret;



	poweron = call_fext_func(FUNC_LEDS, 0x2, LOGOLAMP_POWERON, 0x0);

	if (poweron == FUNC_LED_ON) {

		brightness = LED_HALF;

		always = call_fext_func(FUNC_LEDS, 0x2, LOGOLAMP_ALWAYS, 0x0);

		if (always == FUNC_LED_ON)

			brightness = LED_FULL;

	}

	return brightness;

	ret = call_fext_func(FUNC_LEDS, 0x2, LOGOLAMP_ALWAYS, 0x0);

	if (ret == FUNC_LED_ON)

		return LED_FULL;



	ret = call_fext_func(FUNC_LEDS, 0x2, LOGOLAMP_POWERON, 0x0);

	if (ret == FUNC_LED_ON)

		return LED_HALF;



	return LED_OFF;

}



static enum led_brightness kblamps_get(struct led_classdev *cdev)