Commit 5c08ea76 authored Feb 13, 2019 by Julien Thierry Committed by Greg Kroah-Hartman Feb 20, 2019

ARM: 8810/1: vfp: Fix wrong assignement to ufp_exc



Commit 5df7a99bdd0de4a0480320264c44c04543c29d5a upstream.

In vfp_preserve_user_clear_hwstate, ufp_exc->fpinst2 gets assigned to
itself. It should actually be hwstate->fpinst2 that gets assigned to the
ufp_exc field.

Fixes commit 3aa2df6ec2ca6bc143a65351cca4266d03a8bc41 ("ARM: 8791/1:
vfp: use __copy_to_user() when saving VFP state").

Reported-by: David Binderman <dcb314@hotmail.com>
Signed-off-by: Julien Thierry <julien.thierry@arm.com>
Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
Signed-off-by: David A. Long <dave.long@linaro.org>
Reviewed-by: Julien Thierry <julien.thierry@arm.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 27dd16a0

arch/arm/vfp/vfpmodule.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -579,7 +579,7 @@ int vfp_preserve_user_clear_hwstate(struct user_vfp *ufp,
		*/
		ufp_exc->fpexc = hwstate->fpexc;
		ufp_exc->fpinst = hwstate->fpinst;
		ufp_exc->fpinst2 = ufp_exc->fpinst2;
		ufp_exc->fpinst2 = hwstate->fpinst2;

		/* Ensure that VFP is disabled. */
		vfp_flush_hwstate(thread);