Commit 5b340ea0 authored May 09, 2014 by Dan Carpenter Committed by Mauro Carvalho Chehab May 23, 2014

[media] Staging: dt3155v4l: set error code on failure



We should be returning -ENOMEM here instead of success.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Jingoo Han <jg1.han@samsung.com>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>

parent 68592773

drivers/staging/media/dt3155v4l/dt3155v4l.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -906,8 +906,10 @@ dt3155_probe(struct pci_dev pdev, const struct pci_device_id id)
		if (!pd)
		return -ENOMEM;
		pd->vdev = video_device_alloc();
		if (!pd->vdev)
		if (!pd->vdev) {
		err = -ENOMEM;
		goto err_video_device_alloc;
		}
		*pd->vdev = dt3155_vdev;
		pci_set_drvdata(pdev, pd); /* for use in dt3155_remove() */
		video_set_drvdata(pd->vdev, pd); /* for use in video_fops */