Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5b102782 authored by Balbir Singh's avatar Balbir Singh Committed by Michael Ellerman
Browse files

powerpc/xmon: Enable disassembly files (compilation changes) 



After updating ppc-dis.c, ppc-opc.c and ppc.h the following changes were
made to enable compilation and working of xmon:

  1.  Remove all disassembler_info
  2.  Use xmon's printf/print_address to output data and addresses
      respectively.
  3.  All bfd_* types and casts have been removed.
  4.  Optimizations related to opcd_indices have been removed.
  5.  The dialect is set based on cpu features.
  6.  PPC_OPCODE_CLASSIC is no longer supported in the new
      disassembler.
  7.  VLE opcode parsing and printing has been stripped.
  8.  Coding style conventions used for those routines has
      been retained and it does not match our CodingStyle.
  9.  The highest supported dialect is POWER9.
  10. Defined ATTRIBUTE_UNUSED in ppc-dis.c.
  11. Defined _(x) in ppc-dis.c.

Finally, we remove the dependency on BROKEN so that XMON_DISASSEMBLY can
be enabled again.

Signed-off-by: default avatarBalbir Singh <bsingharora@gmail.com>
Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
parent 08d96e0b

arch/powerpc/Kconfig.debug

+0 −1
Original line number Diff line number Diff line
@@ -115,7 +115,6 @@ config XMON_DEFAULT 
config XMON_DISASSEMBLY

	bool "Include disassembly support in xmon"

	depends on XMON

	depends on BROKEN

	default y

	help

	  Include support for disassembling in xmon. You probably want

arch/powerpc/xmon/ppc-dis.c

+52 −540

File changed.

Preview size limit exceeded, changes collapsed.

arch/powerpc/xmon/ppc-opc.c

+8 −4
Original line number Diff line number Diff line
@@ -19,10 +19,14 @@ 
   Software Foundation, 51 Franklin Street - Fifth Floor, Boston, MA

   02110-1301, USA.  */



#include "sysdep.h"

#include <stdio.h>

#include "opcode/ppc.h"

#include "opintl.h"

#include <linux/stddef.h>

#include <linux/kernel.h>

#include <linux/bug.h>

#include "nonstdio.h"

#include "ppc.h"



#define ATTRIBUTE_UNUSED

#define _(x)	x



/* This file holds the PowerPC opcode table.  The opcode table

   includes almost all of the extended instruction mnemonics.  This

arch/powerpc/xmon/ppc.h

+0 −2
Original line number Diff line number Diff line
@@ -21,8 +21,6 @@ Software Foundation, 51 Franklin Street - Fifth Floor, Boston, MA 02110-1301, US 
#ifndef PPC_H

#define PPC_H



#include "bfd_stdint.h"



#ifdef __cplusplus

extern "C" {

#endif