Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5ada4550 authored by Johan Hovold's avatar Johan Hovold Committed by Linus Torvalds
Browse files

backlight: atmel-pwm-bl: use gpio_is_valid 



Use gpio_is_valid rather than open coding the more restrictive != -1
test.

Signed-off-by: default avatarJohan Hovold <jhovold@gmail.com>
Acked-by: default avatarJingoo Han <jg1.han@samsung.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 7bb8abe6

drivers/video/backlight/atmel-pwm-bl.c

+4 −4
Original line number Diff line number Diff line
@@ -48,7 +48,7 @@ static int atmel_pwm_bl_set_intensity(struct backlight_device *bd) 
		pwm_duty = pwmbl->pdata->pwm_duty_min;



	if (!intensity) {

		if (pwmbl->gpio_on != -1) {

		if (gpio_is_valid(pwmbl->gpio_on)) {

			gpio_set_value(pwmbl->gpio_on,

					0 ^ pwmbl->pdata->on_active_low);

		}
@@ -57,7 +57,7 @@ static int atmel_pwm_bl_set_intensity(struct backlight_device *bd) 
	} else {

		pwm_channel_enable(&pwmbl->pwmc);

		pwm_channel_writel(&pwmbl->pwmc, PWM_CUPD, pwm_duty);

		if (pwmbl->gpio_on != -1) {

		if (gpio_is_valid(pwmbl->gpio_on)) {

			gpio_set_value(pwmbl->gpio_on,

					1 ^ pwmbl->pdata->on_active_low);

		}
@@ -146,7 +146,7 @@ static int atmel_pwm_bl_probe(struct platform_device *pdev) 
	if (retval)

		return retval;



	if (pwmbl->gpio_on != -1) {

	if (gpio_is_valid(pwmbl->gpio_on)) {

		retval = devm_gpio_request(&pdev->dev, pwmbl->gpio_on,

					"gpio_atmel_pwm_bl");

		if (retval)
@@ -196,7 +196,7 @@ static int atmel_pwm_bl_remove(struct platform_device *pdev) 
{

	struct atmel_pwm_bl *pwmbl = platform_get_drvdata(pdev);



	if (pwmbl->gpio_on != -1) {

	if (gpio_is_valid(pwmbl->gpio_on)) {

		gpio_set_value(pwmbl->gpio_on,

					0 ^ pwmbl->pdata->on_active_low);

	}