Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5a5b6ed6 authored by Helmut Schaa's avatar Helmut Schaa Committed by John W. Linville
Browse files

rt2x00: Don't enable broad- and multicast buffering on USB devices 



Since rt2x00 USB devices have no chance to know when a beacon was sent
out in AP mode currently all broad- and multicast traffic is buffered in
mac80211 but never sent out at all.

Unfortunately we have no chance in sending the traffic out after a
DTIM beacon due to hw limitations. Hence, instead of never sending the
buffered traffic out better send it out immediately.

Signed-off-by: default avatarHelmut Schaa <helmut.schaa@googlemail.com>
Reported-by: default avatarLauri Hintsala <lauri.hintsala@bluegiga.com>
Signed-off-by: default avatarIvo van Doorn <IvDoorn@gmail.com>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent c4c18a9d

drivers/net/wireless/rt2x00/rt2500usb.c

+6 −1
Original line number Diff line number Diff line
@@ -1674,10 +1674,15 @@ static int rt2500usb_probe_hw_mode(struct rt2x00_dev *rt2x00dev) 


	/*

	 * Initialize all hw fields.

	 *

	 * Don't set IEEE80211_HW_HOST_BROADCAST_PS_BUFFERING unless we are

	 * capable of sending the buffered frames out after the DTIM

	 * transmission using rt2x00lib_beacondone. This will send out

	 * multicast and broadcast traffic immediately instead of buffering it

	 * infinitly and thus dropping it after some time.

	 */

	rt2x00dev->hw->flags =

	    IEEE80211_HW_RX_INCLUDES_FCS |

	    IEEE80211_HW_HOST_BROADCAST_PS_BUFFERING |

	    IEEE80211_HW_SIGNAL_DBM |

	    IEEE80211_HW_SUPPORTS_PS |

	    IEEE80211_HW_PS_NULLFUNC_STACK;

drivers/net/wireless/rt2x00/rt2800lib.c

+10 −1
Original line number Diff line number Diff line
@@ -3164,11 +3164,20 @@ int rt2800_probe_hw_mode(struct rt2x00_dev *rt2x00dev) 
	 * Initialize all hw fields.

	 */

	rt2x00dev->hw->flags =

	    IEEE80211_HW_HOST_BROADCAST_PS_BUFFERING |

	    IEEE80211_HW_SIGNAL_DBM |

	    IEEE80211_HW_SUPPORTS_PS |

	    IEEE80211_HW_PS_NULLFUNC_STACK |

	    IEEE80211_HW_AMPDU_AGGREGATION;

	/*

	 * Don't set IEEE80211_HW_HOST_BROADCAST_PS_BUFFERING for USB devices

	 * unless we are capable of sending the buffered frames out after the

	 * DTIM transmission using rt2x00lib_beacondone. This will send out

	 * multicast and broadcast traffic immediately instead of buffering it

	 * infinitly and thus dropping it after some time.

	 */

	if (!rt2x00_is_usb(rt2x00dev))

		rt2x00dev->hw->flags |=

			IEEE80211_HW_HOST_BROADCAST_PS_BUFFERING;



	SET_IEEE80211_DEV(rt2x00dev->hw, rt2x00dev->dev);

	SET_IEEE80211_PERM_ADDR(rt2x00dev->hw,

drivers/net/wireless/rt2x00/rt73usb.c

+6 −1
Original line number Diff line number Diff line
@@ -2063,9 +2063,14 @@ static int rt73usb_probe_hw_mode(struct rt2x00_dev *rt2x00dev) 


	/*

	 * Initialize all hw fields.

	 *

	 * Don't set IEEE80211_HW_HOST_BROADCAST_PS_BUFFERING unless we are

	 * capable of sending the buffered frames out after the DTIM

	 * transmission using rt2x00lib_beacondone. This will send out

	 * multicast and broadcast traffic immediately instead of buffering it

	 * infinitly and thus dropping it after some time.

	 */

	rt2x00dev->hw->flags =

	    IEEE80211_HW_HOST_BROADCAST_PS_BUFFERING |

	    IEEE80211_HW_SIGNAL_DBM |

	    IEEE80211_HW_SUPPORTS_PS |

	    IEEE80211_HW_PS_NULLFUNC_STACK;