Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 596816fa authored by Florian Westphal's avatar Florian Westphal Committed by Greg Kroah-Hartman
Browse files

netfilter: ipt_CLUSTERIP: put config struct if we can't increment ct refcount 



[ Upstream commit 8ae56822812ddedc26a152ab1916eb30120b4748 ]

This needs to put() the entry to avoid a resource leak in error path.

Signed-off-by: default avatarFlorian Westphal <fw@strlen.de>
Signed-off-by: default avatarPablo Neira Ayuso <pablo@netfilter.org>
Signed-off-by: default avatarSasha Levin <alexander.levin@microsoft.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent ff8c6751

net/ipv4/netfilter/ipt_CLUSTERIP.c

+6 −2
Original line number Diff line number Diff line
@@ -492,12 +492,15 @@ static int clusterip_tg_check(const struct xt_tgchk_param *par) 
				return PTR_ERR(config);

		}

	}

	cipinfo->config = config;



	ret = nf_ct_netns_get(par->net, par->family);

	if (ret < 0)

	if (ret < 0) {

		pr_info("cannot load conntrack support for proto=%u\n",

			par->family);

		clusterip_config_entry_put(par->net, config);

		clusterip_config_put(config);

		return ret;

	}



	if (!par->net->xt.clusterip_deprecated_warning) {

		pr_info("ipt_CLUSTERIP is deprecated and it will removed soon, "
@@ -505,6 +508,7 @@ static int clusterip_tg_check(const struct xt_tgchk_param *par) 
		par->net->xt.clusterip_deprecated_warning = true;

	}



	cipinfo->config = config;

	return ret;

}