Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 588afcc1 authored by Oliver Neukum's avatar Oliver Neukum Committed by Mauro Carvalho Chehab
Browse files

[media] usbvision fix overflow of interfaces array 

This fixes the crash reported in:
http://seclists.org/bugtraq/2015/Oct/35


The interface number needs a sanity check.

Signed-off-by: default avatarOliver Neukum <oneukum@suse.com>
Cc: Vladis Dronov <vdronov@redhat.com>
Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
parent 3ff863b8

drivers/media/usb/usbvision/usbvision-video.c

+7 −0
Original line number Diff line number Diff line
@@ -1461,6 +1461,13 @@ static int usbvision_probe(struct usb_interface *intf, 
	printk(KERN_INFO "%s: %s found\n", __func__,

				usbvision_device_data[model].model_string);



	/*

	 * this is a security check.

	 * an exploit using an incorrect bInterfaceNumber is known

	 */

	if (ifnum >= USB_MAXINTERFACES || !dev->actconfig->interface[ifnum])

		return -ENODEV;



	if (usbvision_device_data[model].interface >= 0)

		interface = &dev->actconfig->interface[usbvision_device_data[model].interface]->altsetting[0];

	else