Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 57fe1479 authored by Alexey Khoroshilov's avatar Alexey Khoroshilov Committed by David S. Miller
Browse files

smsc911x: Add check for ioremap_nocache() return code 



There is no check for return code of smsc911x_drv_probe()
in smsc911x_drv_probe(). The patch adds one.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: default avatarAlexey Khoroshilov <khoroshilov@ispras.ru>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 8f44c9a4

drivers/net/ethernet/smsc/smsc911x.c

+5 −0
Original line number Diff line number Diff line
@@ -2467,6 +2467,10 @@ static int smsc911x_drv_probe(struct platform_device *pdev) 
	pdata = netdev_priv(dev);

	dev->irq = irq;

	pdata->ioaddr = ioremap_nocache(res->start, res_size);

	if (!pdata->ioaddr) {

		retval = -ENOMEM;

		goto out_ioremap_fail;

	}



	pdata->dev = dev;

	pdata->msg_enable = ((1 << debug) - 1);
@@ -2572,6 +2576,7 @@ static int smsc911x_drv_probe(struct platform_device *pdev) 
	smsc911x_free_resources(pdev);

out_request_resources_fail:

	iounmap(pdata->ioaddr);

out_ioremap_fail:

	free_netdev(dev);

out_release_io_1:

	release_mem_region(res->start, resource_size(res));