Commit 5693ce6f authored Aug 10, 2007 by Cornelia Huck Committed by Martin Schwidefsky Aug 10, 2007

[S390] cio: avoid memory leak on error in css_alloc_subchannel().



sch->lock has been allocated in cio_validate_subchannel(), it must be
freed if cio_modify() fails.

Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>

parent ac078602

drivers/s390/cio/css.c

+1 −0

Original line number	Original line	Diff line number	Diff line
	@@ -79,6 +79,7 @@ css_alloc_subchannel(struct subchannel_id schid)
	sch->schib.pmcw.intparm = (__u32)(unsigned long)sch;		sch->schib.pmcw.intparm = (__u32)(unsigned long)sch;
	ret = cio_modify(sch);		ret = cio_modify(sch);
	if (ret) {		if (ret) {
			kfree(sch->lock);
	kfree(sch);		kfree(sch);
	return ERR_PTR(ret);		return ERR_PTR(ret);
	}		}